| From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
| Subject: | Re: Remove HeapTuple and Buffer dependency for predicate locking functions |
| Date: | 2020-01-28 01:00:53 |
| Message-ID: | CALfoeiux1OKrj=_7q0Zx8YOqJFvBgTphvAcQx2dWMCoCqEYjEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 27, 2020 at 4:47 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> OK, I kept only the small comment change from that little fixup patch,
> and pushed this.
>
> > I had proposed as alternative way in initial email and also later,
> > didn't receive comment on that, so re-posting.
>
> > typedef bool (*AMCheckForSerializableConflictOutCallback) (void *arg);
> ...
> > Just due to void* callback argument aspect I didn't prefer that
> > solution and felt AM performing checks and calling
> > CheckForSerializableConflictOut() seems better. Please let me know
> > how you feel about this.
>
> Yeah. We could always come back to this idea if it looks better once
> we have more experience with new table AMs.
>
Sounds good. Thank You!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kohei KaiGai | 2020-01-28 01:55:11 | Is custom MemoryContext prohibited? |
| Previous Message | Thomas Munro | 2020-01-28 00:46:58 | Re: Remove HeapTuple and Buffer dependency for predicate locking functions |