"inconsistent page found" with checksum and wal_consistency_checking enabled

From: Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
To: pgsql-hackers(at)postgresql(dot)org
Subject: "inconsistent page found" with checksum and wal_consistency_checking enabled
Date: 2017-09-19 20:23:58
Message-ID: CALfoeis5iqrAU-+JAN+ZzXkpPr7+-0OAGv7QUHwFn=-wDy4o4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Currently, page checksum is not masked by Page masking routines used
by wal_consistency_checking facility. So, when running `make installcheck`
with data checksum enabled and wal_consistency_checking='all', it easily
and consistently FATALs with "inconsistent page found".

If anything needs to be masked on Page to perform / pass wal consistency
checking, definitely checksum is not going to match and hence must be
masked as well. Attaching patch to fix the same, installcheck passes with
checksums enabled and wal_consistency_checking='all' with the fix.

Clubbed to perform the masking with lsn as it sounds logical to have them
together, as lsn is masked is all the cases so far and such is needed for
checksum as well.

Thank You,
Ashwin Agrawal

Attachment Content-Type Size
mask_checksum.diff text/plain 5.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-09-19 20:25:18 Re: pgsql: Make new crash restart test a bit more robust.
Previous Message Thomas Munro 2017-09-19 20:17:50 Re: why not parallel seq scan for slow functions