Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Karina Litskevich <litskevichkarina(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add missing tab completion for ALTER TABLE ADD COLUMN IF NOT EXISTS
Date: 2024-12-08 04:22:53
Message-ID: CALdSSPixespcqL++vmOXNApmRoDXZ6yBSD+E7NfP0DvGCLAKXw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 8 Dec 2024 at 03:35, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>
> Hi,
> I took a quick look at this patch series, and it looks generally fine to
> me. Barring objections, I'll get it committed. Yes, there's a couple
> cosmetic details, and it needs a pgindent run, but I think I can take
> care of that ...
>
Thank you for taking a look.

PFA v6 with last Karina's review comments addressed.

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v6-0003-Add-missing-tab-completion-for-CREATE-TEMP-TABLE-.patch application/octet-stream 1.2 KB
v6-0001-Enhance-tab-completion-to-ALTER-TYPE-ADD-ATTRIBUT.patch application/octet-stream 1.2 KB
v6-0002-Add-CASCADE-RESRTICT-to-ALTER-TYPE-patterns.patch application/octet-stream 2.4 KB
v6-0004-Suggest-table-access-method-for-create-maateriali.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2024-12-08 04:23:26 Re: Trim the heap free memory
Previous Message Noah Misch 2024-12-08 03:46:14 Fix early elog(FATAL)