Re: Fix gistkillitems & add regression test to microvacuum

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com>
Cc: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Fix gistkillitems & add regression test to microvacuum
Date: 2026-03-18 05:42:08
Message-ID: CALdSSPirzFew+O0ZVDh81f8m_cwd7SMdRMZwGa-uy7zg078dGQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 11 Feb 2026 at 17:18, Soumya S Murali
<soumyamurali(dot)work(at)gmail(dot)com> wrote:
>
> Hi all,
>
> Thank you for the updated patch.
> I reproduced the issue locally by filling a GiST root page, deleting
> all tuples, and triggering a microvacuum by an index-only scan.
> With the patch, The root page is now handled consistently with other
> leaf pages. so->curBlkno and so->curPageLSN are properly set during
> scan, and gistkillitems() operates safely and correctly on the root
> page.
> Based on runtime validation and code inspection, the fix LGTM.
>

Rebased due to f5eb854ab6d[0]

I have added a [0]committer to CC.

Andres, can you please take a look at this thread, if by chance you
have spare time for it? You have changed kill tuples-related logic
frequently, so you might be interested...

[0] https://git.postgresql.org/cgit/postgresql.git/commit/?id=f5eb854ab6d6281ec2d3143657944bdda6676341

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v3-0001-Fix-gistkillitems-for-GiST-ROOT-page.patch application/octet-stream 3.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message 2026-03-18 06:12:41 RE: [Proposal] Adding Log File Capability to pg_createsubscriber
Previous Message Ashutosh Sharma 2026-03-18 05:27:02 Re: synchronized_standby_slots behavior inconsistent with quorum-based synchronous replication