Re: GIN pageinspect support for entry tree and posting tree

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Subject: Re: GIN pageinspect support for entry tree and posting tree
Date: 2026-01-08 18:00:57
Message-ID: CALdSSPhcbAM8HdtfDHQVE=UNMoAH7-QmUGPKbAkxMTVk=3picg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 8 Jan 2026 at 22:11, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> On Thu, 8 Jan 2026 at 21:49, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> > > On 8 Jan 2026, at 01:57, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> > >
> > > PFA v10
> >
> > Also it seems that you used something that is not pgindent.
>
> Why
>
> > Looks like clang-format with default settings.
>
> I use "./src/tools/pg_bsd_indent/pg_bsd_indent -l79 -di12 -nfc1 -nlp
> -sac ./contrib/pageinspect/ginfuncs.c"
>
>
>
>
> --
> Best regards,
> Kirill Reshke

Okay, after off-list discussion looks like my options to pg_bsd_indent
are bad, better is:

"./src/tools/pg_bsd_indent/pg_bsd_indent -bad -bap -bbb -bc -bl -cli1
-cp33 -cdb -nce -d0 -di12 -nfc1 -i4 -l79 -lp -lpl -nip -npro -sac -tpg
-ts4 ./contrib/pageinspect/ginfuncs.c"

And still this is not OK to use plain pg_bsd_indent and thus I used
" ./src/tools/pgindent/pgindent ./contrib/pageinspect/ginfuncs.c"

v11 with this and commit message polishing

--
Best regards,
Kirill Reshke

Attachment Content-Type Size
v11-0002-GIN-pageinspect-support-for-entry-tree-and-posti.patch application/octet-stream 29.8 KB
v11-0001-Preliminary-cleanup.patch application/octet-stream 5.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-01-08 18:19:39 Re: improve performance of pg_dump with many sequences
Previous Message Tom Lane 2026-01-08 17:50:52 Re: Always show correct error message for statement timeouts, fixes random buildfarm failures