| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound |
| Date: | 2023-04-04 09:57:45 |
| Message-ID: | CALT9ZEFW8Xbw0=HuQMLjkzayO=MtkqfepKU1TdzyZy4jyrUtBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
I've looked into the patches v4.
For 0001:
I think long "not accepting commands that generate" is equivalent to
more concise "can't generate".
For 0003:
I think double mentioning of Vacuum at each errhist i.e.: "Execute a
database-wide VACUUM in that database" and "...or run a manual
database-wide VACUUM." are redundant. The advice "Ensure that
autovacuum is progressing,..." is also not needed after advice to
"Execute a database-wide VACUUM in that database".
For all:
In a errhint's list what _might_ be done I think AND is a little bit
better that OR as the word _might_ means that each of the proposals in
the list is a probable, not a sure one.
The proposed changes are in patchset v5.
Kind regards,
Pavel Borisov,
Supabase.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0002-This-recommendation-is-outdated-for-some-time-now.patch | application/octet-stream | 3.8 KB |
| v5-0001-Correct-the-docs-and-messages-about-preventing-XI.patch | application/octet-stream | 9.1 KB |
| v5-0003-Modify-the-hints-about-preventing-XID-wraparound.patch | application/octet-stream | 9.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-04-04 10:04:35 | Re: Split index and table statistics into different types of stats |
| Previous Message | Drouvot, Bertrand | 2023-04-04 09:47:46 | Re: Minimal logical decoding on standbys |