| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Konstantin Knizhnik <knizhnik(at)garret(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Index range search optimization |
| Date: | 2023-09-25 10:11:53 |
| Message-ID: | CALT9ZEE98O=SPZATLg-9ux32uwrJR2NhN31UCcEUzF-nDA0v+Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sorry, I've mistaken with attached version previously. Correct v5 attached.
On Mon, 25 Sept 2023 at 13:58, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
>
> Hi, Alexander!
>
> I found and fixed a couple of naming issues that came to v4 from
> earlier patches.
> Also, I added initialization of requiredMatchedByPrecheck in case of first page.
>
> Please see patch v5.
>
> One more doubt about naming. Calling function
> _bt_checkkeys(IndexScanDesc scan, IndexTuple tuple, int tupnatts,
> ScanDirection dir, bool *continuescan, bool requiredMatchedByPrecheck)
> as
> (void) _bt_checkkeys(scan, itup, indnatts, dir,
> &requiredMatchedByPrecheck, false);
> looks little bit misleading because of coincidence of names of 5 and 6
> arguments.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-PATCH-Skip-checking-of-scan-keys-required-for-dir.patch | application/octet-stream | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2023-09-25 10:13:35 | Re: Make --help output fit within 80 columns per line |
| Previous Message | Richard Guo | 2023-09-25 10:11:41 | Fix a wrong comment in setrefs.c |