| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
| Cc: | Greg Stark <stark(at)mit(dot)edu>, Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Hywel Carver <hywel(at)skillerwhale(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing unneeded self joins |
| Date: | 2022-08-28 23:39:09 |
| Message-ID: | CALNJ-vTyL-LpvSOPZxpC63Et3LJLUAFZSfRqGEhT5Rj7_EEj7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 26, 2022 at 3:02 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Hi,
> For v36-0001-Remove-self-joins.patch :
>
> bq removes inner join of plane table to itself
>
> plane table -> plain table
>
> For relation_has_unique_index_ext(), it seems when extra_clauses is NULL,
> there is no need to compute `exprs`.
>
> Cheers
>
For remove_self_joins_recurse():
+ if (bms_num_members(relids) > join_collapse_limit)
+ break;
The above line just comes out of the switch statement. This check should be
done again between foreach and switch.
Otherwise the above check wouldn't achieve what you want.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-08-29 01:06:55 | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |
| Previous Message | Nathan Bossart | 2022-08-28 23:14:05 | Re: effective_multixact_freeze_max_age issue |