Re: [PATCH] Partial foreign key updates in referential integrity triggers

From: Zhihong Yu <zyu(at)yugabyte(dot)com>
To: Paul Martinez <hellopfm(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: [PATCH] Partial foreign key updates in referential integrity triggers
Date: 2021-09-02 20:54:52
Message-ID: CALNJ-vTF0+hhRYYB866jFWeHQeVSzjyADy0+VJzhQ6_-LnkypA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 2, 2021 at 12:11 PM Paul Martinez <hellopfm(at)gmail(dot)com> wrote:

> On Wed, Sep 1, 2021 at 4:11 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > This patch no longer applies, can you please submit a rebased version?
> It
> > currently fails on catversion.h, to keep that from happening repeatedly
> you can
> > IMO skip that from the patch submission.
>
> Ah, understood. Will do that in the future. Attached are rebased patches,
> not
> including catversion.h changes, for both the ON UPDATE/DELETE case, and the
> ON DELETE only case.
>
> - Paul
>
Hi,
+ case RI_TRIGTYPE_DELETE:
+ queryno = is_set_null
+ ? RI_PLAN_ONDELETE_SETNULL_DOUPDATE
+ : RI_PLAN_ONDELETE_SETDEFAULT_DOUPDATE;

Should the new symbols be renamed ?

RI_PLAN_ONDELETE_SETNULL_DOUPDATE -> RI_PLAN_ONDELETE_SETNULL_DODELETE
RI_PLAN_ONDELETE_SETDEFAULT_DOUPDATE -> RI_PLAN_ONDELETE_SETDEFAULT_DODELETE

Cheers

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-09-02 21:18:56 Re: a misbehavior of partition row movement (?)
Previous Message Mark Dilger 2021-09-02 20:44:58 Re: Skipping logical replication transactions on subscriber side