| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pchampion(at)vmware(dot)com, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Subject: | Re: Table AM modifications to accept column projection lists |
| Date: | 2021-01-01 00:34:58 |
| Message-ID: | CALNJ-vRoS=K9dqv2thYCnNXfo8uEbZbQv1NizGLCGx9KDEpK0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Soumyadeep:
Happy New Year.
+typedef struct neededColumnContext
+{
+ Bitmapset **mask;
+ int n;
+ * n specifies the number of allowed entries in mask: we use
+ * it for bounds-checking in the walker above.
I think the code would be easier to read if the above comment is moved or
copied for field n of neededColumnContext
Cheers
On Thu, Dec 31, 2020 at 1:03 PM Soumyadeep Chakraborty <
soumyadeep2007(at)gmail(dot)com> wrote:
> Hey Masahiko,
>
> I added it to the Jan CF (https://commitfest.postgresql.org/31/2922/).
>
> PFA a rebased version against latest head.
>
> Regards,
> Soumyadeep
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josef Šimánek | 2021-01-01 01:25:31 | [PATCH] Simple progress reporting for COPY command |
| Previous Message | Peter Geoghegan | 2021-01-01 00:23:38 | Re: Deleting older versions in unique indexes to avoid page splits |