Re: Documentation to upgrade logical replication cluster

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Subject: Re: Documentation to upgrade logical replication cluster
Date: 2024-02-22 13:34:42
Message-ID: CALDaNm3d4nSurbVDo4a7m=L-2CGq00_LcpbeadADm1LOM7GMiw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 22 Feb 2024 at 09:35, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are some minor comments for patch v8-0001.
>
> ======
> doc/src/sgml/glossary.sgml
>
> 1.
> + <glossdef>
> + <para>
> + A set of publisher and subscriber instances with publisher instance
> + replicating changes to the subscriber instance.
> + </para>
> + </glossdef>
>
> /with publisher instance/with the publisher instance/

Modified

> ~~~
>
> 2.
> There are 2 SQL fragments but they are wrapped differently (see
> below). e.g. it is not clear why is the 2nd fragment wrapped since it
> is shorter than the 1st. OTOH, maybe you want the 1st fragment to
> wrap. Either way, consistency wrapping would be better.

Modified

Thanks for the comments, the attached v9 version patch has the changes
for the same.

I have added a commitfest entry for this:
https://commitfest.postgresql.org/47/4848/

Regards,
Vignesh

Attachment Content-Type Size
v9-0001-Documentation-for-upgrading-logical-replication-c.patch text/x-patch 34.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-02-22 13:55:48 Re: Add missing error codes to PANIC/FATAL error reports in xlog.c and relcache.c
Previous Message Matthias van de Meent 2024-02-22 13:34:00 Re: btree: downlink right separator/HIKEY optimization