Buildfarm failure in crake

From: vignesh C <vignesh21(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Buildfarm failure in crake
Date: 2021-03-03 03:16:41
Message-ID: CALDaNm3L=ROeb=4rKf0XMN0CqrEnn6T=-44m4fsDAhcw-OUCVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed there is buildfarm failure in crake, it fails with the
following error:
Mar 02 21:22:56 ./src/test/recovery/t/001_stream_rep.pl: Variable
declared in conditional statement at line 88, column 2. Declare
variables outside of the condition.
([Variables::ProhibitConditionalDeclarations] Severity: 5)

I felt the variable declaration and the assignment need to be split as
it involves conditional statements. I have attached a patch which will
help in fixing the problem.
Thoughts?

Regards,
Vignesh

Attachment Content-Type Size
buildfarm_failure.patch text/x-patch 609 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message miyake_kouta 2021-03-03 03:27:11 Re: [PATCH] psql : Improve code for help option
Previous Message Peter Geoghegan 2021-03-03 03:10:32 Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.