| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Zheng Li <zhengli10(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Support logical replication of DDLs |
| Date: | 2022-10-07 05:07:20 |
| Message-ID: | CALDaNm3F9GvQ9bPrxobhqkUKP3HmrRZGCU3EX0xt3=Ef0-Reaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
On Fri, 7 Oct 2022 at 08:10, Zheng Li <zhengli10(at)gmail(dot)com> wrote:
>
> > Thanks for the new patch-set.
> > Could you add the changes to patch 1 and patch 2, rather than adding a
> > new patch?
> > Otherwise, we'll have a separate patch for each command and it will
> > take double work to keep it updated
> > for each new command added.
>
> OK. Here is the consolidated patch set. TEXT SEARCH and TRANSFORM
> commands are consolidated into patch 1 and patch 2.
> I was wondering if keeping the changes for each command separate makes
> it easier to review. Maybe just for some commands that need special
> handling.
I agree, let's keep the changes for the commands in patch 1 and patch
2 if we are following the same parsing mechanism that is being
followed for the existing commands. If any command needs to be handled
in a more complex manner which is different from the existing parsing
mechanism then we can think of keeping it in a separate patch.
CFBOT at [1] was failing as some additional changes were required to
handle the meson build errors and warnings. The attached patch has the
changes for the same.
[1] - https://cirrus-ci.com/task/5343002330660864
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v25-0004-Test-cases-for-DDL-replication.patch | text/x-patch | 24.6 KB |
| v25-0002-Support-DDL-replication.patch | text/x-patch | 131.0 KB |
| v25-0003-Support-CREATE-TABLE-AS-SELECT-INTO.patch | text/x-patch | 15.0 KB |
| v25-0001-Functions-to-deparse-DDL-commands.patch | text/x-patch | 279.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ron | 2022-10-07 17:11:43 | Re: pg_restore creates public schema? |
| Previous Message | Zheng Li | 2022-10-07 02:40:25 | Re: Support logical replication of DDLs |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-10-07 05:14:14 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Amit Kapila | 2022-10-07 05:00:43 | Re: Perform streaming logical transactions by background workers and parallel apply |