Re: Add last_vacuum_index_scans in pg_stat_all_tables

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Ken Kato <katouknl(at)oss(dot)nttdata(dot)com>
Cc: Kshetrapaldesi Tutika <kshetra1(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add last_vacuum_index_scans in pg_stat_all_tables
Date: 2023-01-03 10:40:58
Message-ID: CALDaNm2erFSvSN_J=B_4UTCeA6LSS-sPOH_FE_Qi0txHWXMTRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 4 Oct 2022 at 10:20, Ken Kato <katouknl(at)oss(dot)nttdata(dot)com> wrote:
>
> > The problem is that you're not closing the <entry>
>
> Thank you for the reviews and comments.
> I closed the <entry> so that the problem should be fixed now.

The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
e351f85418313e97c203c73181757a007dfda6d0 ===
=== applying patch ./show_index_scans_in_pg_stat_all_tables_v3.patch
patching file src/backend/utils/activity/pgstat_relation.c
Hunk #1 succeeded at 209 (offset 1 line).
Hunk #2 FAILED at 232.
1 out of 2 hunks FAILED -- saving rejects to file
src/backend/utils/activity/pgstat_relation.c.rej
patching file src/include/pgstat.h
Hunk #1 FAILED at 366.
1 out of 2 hunks FAILED -- saving rejects to file src/include/pgstat.h.rej
patching file src/test/regress/expected/rules.out
Hunk #1 succeeded at 1800 (offset 8 lines).
Hunk #2 succeeded at 2145 (offset 11 lines).
Hunk #3 succeeded at 2193 (offset 14 lines).

[1] - http://cfbot.cputube.org/patch_41_3756.log

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2023-01-03 10:48:45 Re: Allow placeholders in ALTER ROLE w/o superuser
Previous Message vignesh C 2023-01-03 10:37:37 Re: [Proposal] Add foreign-server health checks infrastructure