| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: persist logical slots to disk during shutdown checkpoint |
| Date: | 2023-09-07 04:43:09 |
| Message-ID: | CALDaNm2e2f5TtFCKbMs7EwuU2y_u56BRApomfA94MTedo-DpPw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 6 Sept 2023 at 12:09, Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> Other than that the patch LGTM.
pgindent reported that the new comments added need to be re-adjusted,
here is an updated patch for the same.
I also verified the following: a) patch applies neatly on HEAD b) make
check-world passes c) pgindent looks good d) pgperltiy was fine e)
meson test runs were successful. Also checked that CFBot run was fine
for the last patch.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-Persist-logical-slots-to-disk-during-a-shutdown-c.patch | text/x-patch | 9.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2023-09-07 05:29:56 | psql help message contains excessive indentations |
| Previous Message | Michael Paquier | 2023-09-07 04:36:30 | Re: Unlogged relation copy is not fsync'd |