| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Invalidate the subscription worker in cases where a user loses their superuser status |
| Date: | 2023-09-27 05:43:42 |
| Message-ID: | CALDaNm2JwPmX0rhkTyjGRQmZjwbKax=3Ytgw2KY9msDPPNGmBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 26 Sept 2023 at 13:03, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are some comments for patch v2-0001.
> ======
> src/test/subscription/t/027_nosuperuser.pl
>
> 3.
> # The apply worker should get restarted after the superuser prvileges are
> # revoked for subscription owner alice.
>
> typo
>
> /prvileges/privileges/
Modified
> ~
>
> 4.
> +# After the user becomes non-superuser the apply worker should be restarted and
> +# it should fail with 'password is required' error as password option is not
> +# part of the connection string.
>
> /as password option/because the password option/
Modified
The attached v3 version patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Restart-the-apply-worker-if-the-subscription-owne.patch | text/x-patch | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-27 05:46:01 | Re: Could not run generate_unaccent_rules.py script when update unicode |
| Previous Message | Suraj Kharage | 2023-09-27 05:40:53 | Re: pg_upgrade --check fails to warn about abstime |