Re: Added schema level support for publication.

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Subject: Re: Added schema level support for publication.
Date: 2021-10-21 13:16:58
Message-ID: CALDaNm1onqBEr0WE_e7=CNw3bURfrGRmbMjX31d-nx3FGLS10A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Oct 21, 2021 at 4:41 AM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
>
> On Thu, Oct 21, 2021 at 3:25 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Attached v44 patch as the fixes for the same.
> >
>
> Regarding the documentation, I think some minor updates are needed in:
> doc/src/sgml/logical-replication.sgml.
> For example, currently it says:
> Publications may currently only contain tables. Objects must be
> added explicitly, except when a publication is created for
> <literal>ALL TABLES</literal>.
> There is also some security-related information in this file which may
> need updating for ALL TABLES IN SCHEMA.

Modified

> Also, I'm not sure the documentation updates in the patches clearly
> define how partitions relate to ALL TABLES IN SCHEMA.
> For example, if a partitioned table belongs to a different schema to
> that of a child partition that belongs to a schema specified for ALL
> TABLES IN SCHEMA, is it implicitly included in the publication or not
> included?

Added

Thanks for the comments, the attached v45 patch has the fix for the same.

Regards,
Vignesh

Attachment Content-Type Size
v45-0001-Allow-publishing-the-tables-of-schema.patch text/x-patch 162.8 KB
v45-0002-Add-tap-tests-for-the-schema-publication-feature.patch text/x-patch 9.5 KB
v45-0003-Add-new-pg_publication_objects-view-to-display-T.patch text/x-patch 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-10-21 13:19:24 Re: Added schema level support for publication.
Previous Message Joe Conway 2021-10-21 13:09:26 Re: [RFC] speed up count(*)