| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Greg Nancarrow <gregn4422(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alastair Turner <minion(at)decodable(dot)me>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Parallel copy |
| Date: | 2020-10-14 09:53:57 |
| Message-ID: | CALDaNm1n1xW43neXSGs=c7zt-mj+JHHbubWBVDYT9NfCoF8TuQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 9, 2020 at 12:10 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> While looking at the latest code, I observed below issue in patch
> v6-0003-Allow-copy-from-command-to-process-data-from-file:
>
> + /* Estimate the size for shared information for PARALLEL_COPY_KEY_CSTATE */
> + est_cstateshared = MAXALIGN(sizeof(SerializedParallelCopyState));
> + shm_toc_estimate_chunk(&pcxt->estimator, est_cstateshared);
> + shm_toc_estimate_keys(&pcxt->estimator, 1);
> +
> + strsize = EstimateCstateSize(pcxt, cstate, attnamelist, &whereClauseStr,
> + &rangeTableStr, &attnameListStr,
> + ¬nullListStr, &nullListStr,
> + &convertListStr);
>
> Here, do we need to separately estimate the size of
> SerializedParallelCopyState when it is also done in
> EstimateCstateSize?
This is not required, this has been removed in the attached patches.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Copy-code-readjustment-to-support-parallel-copy.patch | text/x-patch | 15.4 KB |
| v7-0002-Framework-for-leader-worker-in-parallel-copy.patch | text/x-patch | 29.0 KB |
| v7-0003-Allow-copy-from-command-to-process-data-from-file.patch | text/x-patch | 66.3 KB |
| v7-0004-Documentation-for-parallel-copy.patch | text/x-patch | 2.7 KB |
| v7-0005-Tests-for-parallel-copy.patch | text/x-patch | 34.5 KB |
| v7-0006-Parallel-Copy-For-Binary-Format-Files.patch | text/x-patch | 25.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2020-10-14 10:11:49 | Re: Transactions involving multiple postgres foreign servers, take 2 |
| Previous Message | Amit Langote | 2020-10-14 09:51:42 | Re: partition routing layering in nodeModifyTable.c |