Re: Include sequences in publications created by pg_createsubscriber

On Wed, 2 Sept 2026 at 07:44, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> V9 overall looks good. A few small comments:
>
> 1
> ```
> +# run pg_createsubscriber with '--all' with debug verbose logging enabled
> my ($stdout, $stderr) = run_command(
> [
> 'pg_createsubscriber',
> '--verbose',
> + '--verbose',
> ```
>
> The test already had —verbose, adding the option again is redundant.

This was done intentionally to run in debug logging mode to verify the
create publication command includes ALL SEQUENCES or not. Added a
comment on top of test to avoid confusion.

> 2
> ```
> + Create a publication and replication slot for each specified database
> + on the source server. If the <option>--publication</option> option is
> + specified, the user-specified publication is used, which includes the
> + objects defined by that publication. Otherwise,
> ```
>
> This statement doesn’t seem precise to me. --publication might specify a non-existing publication, in which case a new publication will be created, but “the user-specified publication is used” seems to imply that the specified publication must already exist.

Update the documents to clarify this.

The attached v10 version patch has the changes for the same.

Regards,
Vignesh