Re: FETCH FIRST clause PERCENT option

From: Surafel Temesgen <surafel3000(at)gmail(dot)com>
To: Mark Dilger <hornschnorter(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: FETCH FIRST clause PERCENT option
Date: 2018-11-25 09:00:43
Message-ID: CALAY4q-7FxvHsFxQ=V6FonKX1f7+sxAXS2Dix7SF=3zP2qQd7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> I messed around with your changes to the grammar and it seems you don't
> need to add PERCENT as a reserved keyword. Moving this to the unreserved
> keyword section does not cause any shift/reduce errors, and the regression
> tests still pass. Relative to your patch v4, these changes help:
>
>
In sql standard PERCENT list as reserved world so i don't think it is a
thing that can change by me.
I think the main reason create_table fail in test_ddl_deparse is because
i don't surround PERCENT key word in
/src/test/regress/expected/create_table.out too

regards
Surafel

Attachment Content-Type Size
fetch-wth-percent-v5.patch text/x-patch 35.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2018-11-25 10:24:03 Re: FETCH FIRST clause PERCENT option
Previous Message Thomas Munro 2018-11-25 08:56:41 Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.