| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-26 01:04:01 |
| Message-ID: | CAL9smLDZjh0CSwJSRSh1GTUKwSAXUpYuFMGt4Lu7tVZA-axitQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Oct 25, 2017 at 5:32 PM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> On Mon, Oct 23, 2017 at 6:50 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Okay, attached is what I think a fully implemented patch should look
> > like. On top of what Andrew has done, I added and reworked the
> > following:
> > - removed duplicate error handling.
> > - documented the function in funcapi.h and funcapi.c.
> > - Added a new section in funcapi.h to outline that this is for support
> > of VARIADIC inputs.
> > I have added a commit message as well. Hope this helps.
>
> For the sake of the archives, the introduction of
> extract_variadic_args is committed with f3c6e8a2, and the JSON fixes
> with 18fc4ecf. Thanks Andrew for the commit, and thanks Tom, Andrew
> and Dmitry for the reviews.
Thx yo.
.m
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-26 05:20:06 | Re: BUG #14872: libpq requires a home directory |
| Previous Message | Tom Lane | 2017-10-25 22:40:20 | Re: BUG #14872: libpq requires a home directory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2017-10-26 01:44:39 | Re: Continuous integration on Windows? |
| Previous Message | David Rowley | 2017-10-25 21:59:23 | Removing [Merge]Append nodes which contain a single subpath |