Re: DSA failed to allocate memory

On Mon, Mar 28, 2022 at 3:53 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:

> Hi Dongming,
>
> Thanks for the report, and for working on the fix. Can you please
> create a commitfest entry (if you haven't already)? I plan to look at
> this soon, after the code freeze.

I created a commitfest entry https://commitfest.postgresql.org/38/3607/.
Thanks for your review.

Are you proposing that the test_dsa module should be added to the
> tree? If so, some trivial observations: "#ifndef
> HAVE_INT64_TIMESTAMP" isn't needed anymore (see commit b6aa17e0, which
> is in all supported branches), the year should be updated, and we use
> size_t instead of Size in new code.
>
Yes, I think test_dsa is very helpful and necessary to develop dsa related
features. I have removed the HAVE_INT64_TIMESTAMP related code.
Most of the code for test_dsa comes from your patch[1] and I add some
test cases.

In addition, I add a few OOM test cases that allocate a fixed size of
memory
until the memory overflows, run it twice and compare the amount of memory
they allocate. These cases will fail on the current master branch.

[1]
https://www.postgresql.org/message-id/CAEepm%3D3U7%2BRo7%3DECeQuAZoeFXs8iDVX56NXGCV7z3%3D%2BH%2BWd0Sw%40mail.gmail.com
--
Best Regards,
Dongming