Re: Fix documentation for max_wal_size and min_wal_size

Hi,

On Fri, Apr 14, 2023 at 1:01 AM Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
wrote:

> At Thu, 13 Apr 2023 12:01:04 -0700, sirisha chamarthi <
> sirichamarthi22(at)gmail(dot)com> wrote in
> > The documentation [1] says max_wal_size and min_wal_size defaults are 1GB
> > and 80 MB respectively. However, these are configured based on the
> > wal_segment_size and documentation is not clear about it. Attached a
> patch
> > to fix the documentation.
> >
> > [1] https://www.postgresql.org/docs/devel/runtime-config-wal.html
>
> Good catch! Now wal_segment_size is easily changed.
>
> - The default is 1 GB.
> + The default value is configured to maximum of 64 times the
> <varname>wal_segment_size</varname> or 1 GB.
> - The default is 80 MB.
> + The default value is configured to maximum of 5 times the
> <varname>wal_segment_size</varname> or 80 MB.
>
> However, I believe that most users don't change the WAL segment size,
> so the primary information is that the default sizes are 1GB and 80MB.
>
> So, I personally think it should be written like this: "The default
> size is 80MB. However, if you have changed the WAL segment size from
> the default of 16MB, it will be five times the segment size.", but I'm
> not sure what the others think about this..

This looks good to me.

Thanks,
Sirisha