| From: | yuzuko <yuzukohosoya(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu> |
| Subject: | Re: Autovacuum on partitioned table (autoanalyze) |
| Date: | 2020-08-17 06:11:28 |
| Message-ID: | CAKkQ50_+AXKTS4JUuoD4HDboLddeXgmDZfhJ+oahirnZGKOxbw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I'm sorry for the late reply.
> This version seems to fail under Werror which is used in the Travis builds:
>
> autovacuum.c: In function ‘relation_needs_vacanalyze’:
> autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
> anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
> ^
> autovacuum.c:2972:9: note: ‘reltuples’ was declared here
> float4 reltuples; /* pg_class.reltuples */
> ^
>
I attach the latest patch that solves the above Werror.
Could you please check it again?
--
Best regards,
Yuzuko Hosoya
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| v9_autovacuum_on_partitioned_table.patch | application/octet-stream | 14.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-08-17 06:40:26 | proposal: enhancing plpgsql debug API - returns text value of variable content |
| Previous Message | Masahiko Sawada | 2020-08-17 06:07:39 | Re: display offset along with block number in vacuum errors |