Re: advanced partition matching algorithm for partition-wise join

From: Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: advanced partition matching algorithm for partition-wise join
Date: 2017-09-04 12:30:13
Message-ID: CAKcux6kinAwQFbk9Ce5_04UdKhrRm+SvpM-Cwz_Zc2Yqja+CYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Sep 2, 2017 at 12:42 AM, Ashutosh Bapat <
ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:

> PFA the patches rebased on the latest sources. There are also fixes
> for some of the crashes and bugs reported. I haven't yet included the
> testcase patch in the main patchset.
>
> On Mon, Aug 28, 2017 at 12:44 PM, Rajkumar Raghuwanshi
> <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com> wrote:
> > On Mon, Aug 21, 2017 at 12:43 PM, Ashutosh Bapat
> > <ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> >>
> >> TODOs
> >> -----------
> >> 1. Add tests for advanced partition matching algorithm
> >
> >
> > Hi Ashutosh,
> >
> > I have applied all partition-wise-join patches (v26) and tested feature.
> I
> > have modified partition_join.sql file and added extra test cases to test
> > partition matching.
> >
> > Attaching WIP test case patch which as of now have some server crashes
> and a
> > data corruptions issue which is commented in the file itself and need to
> be
> > removed once issue got solved. Also some of queries is not picking or
> > picking partition-wise-join as per expectation which may need some
> > adjustment.
> >
>

I have applied v27 patches and tested feature. Also tried to reduce
regression diff with the
existing partition_join.sql by adding new partition instead of changing
original partition bounds.

Attached WIP patch have a server crash and some wrong output which need to
be fixed. I have
commented these issue in patch itself, Please take a look and let me know
if it need more
changes.

Attachment Content-Type Size
advance_partition_matching_test_v1.patch text/x-patch 215.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-09-04 12:30:18 Re: Release Note changes
Previous Message Simon Riggs 2017-09-04 12:27:54 Re: Release Note changes