Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)

On Sun, Nov 2, 2025 at 6:24 AM Bryan Green <dbryan(dot)green(at)gmail(dot)com> wrote:
[..snip]

Thanks for working on this Bryan! This looks good to me, perhaps we
should set it to Ready for Committer?. Just to provide some
transparency, one can see it working properly even without access to
win32 via public CI [1] - that is generating proper win32 backtrace
dump - when asked to do this via [2] (just have public
postgres-public-CI connected to Cirrus, and put something like below
into the test, so it dumps the info to the log):
SET backtrace_functions = 'typenameType';
CREATE TABLE tab (id invalidtype);
RESET backtrace_functions

Pasting log in case it will disappear in future:

2026-01-06 07:47:22.102 GMT client backend[5924] pg_regress/backtrace
ERROR: type "invalidtype" does not exist at character 22
2026-01-06 07:47:22.102 GMT client backend[5924] pg_regress/backtrace
BACKTRACE:
typenameType+0x97 [0x7ff6376f7987]
[c:\cirrus\src\backend\parser\parse_type.c:270]
transformColumnType+0x27 [0x7ff637704267]
[c:\cirrus\src\backend\parser\parse_utilcmd.c:4364]
transformColumnDefinition+0x284 [0x7ff6376fe4a4]
[c:\cirrus\src\backend\parser\parse_utilcmd.c:655]
transformCreateStmt+0x50f [0x7ff6376f952f]
[c:\cirrus\src\backend\parser\parse_utilcmd.c:283]
ProcessUtilitySlow+0x26c [0x7ff6378503ac]
[c:\cirrus\src\backend\tcop\utility.c:1141]
standard_ProcessUtility+0xfef [0x7ff63784d52f]
[c:\cirrus\src\backend\tcop\utility.c:1074]
ProcessUtility+0x169 [0x7ff63784c529]
[c:\cirrus\src\backend\tcop\utility.c:528]
PortalRunUtility+0x13d [0x7ff63784b5fd]
[c:\cirrus\src\backend\tcop\pquery.c:1158]
PortalRunMulti+0x2a2 [0x7ff63784b922]
[c:\cirrus\src\backend\tcop\pquery.c:1308]
PortalRun+0x302 [0x7ff63784a5b2] [c:\cirrus\src\backend\tcop\pquery.c:787]
exec_simple_query+0x59d [0x7ff6378469cd]
[c:\cirrus\src\backend\tcop\postgres.c:1286]
PostgresMain+0xaa8 [0x7ff6378443b8]
[c:\cirrus\src\backend\tcop\postgres.c:4779]
BackendMain+0x115 [0x7ff63783dec5]
[c:\cirrus\src\backend\tcop\backend_startup.c:125]
SubPostmasterMain+0x2d6 [0x7ff63772b016]
[c:\cirrus\src\backend\postmaster\launch_backend.c:692]
main+0x329 [0x7ff6375d8d29] [c:\cirrus\src\backend\main\main.c:222]
invoke_main+0x39 [0x7ff637c06b39]
[D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79]
__scrt_common_main_seh+0x12e [0x7ff637c06a8e]
[D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288]
__scrt_common_main+0xe [0x7ff637c0694e]
[D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331]
mainCRTStartup+0xe [0x7ff637c06bae]
[D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17]
BaseThreadInitThunk+0x10 [0x7fff63734cb0]
RtlUserThreadStart+0x2b [0x7fff63c7edcb]

-J.

[1] - https://api.cirrus-ci.com/v1/artifact/task/4843974281658368/testrun/build/testrun/regress/regress/log/postmaster.log
[2] - https://api.cirrus-ci.com/v1/artifact/task/4843974281658368/testrun/build/testrun/regress/regress/regression.diffs