| From: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, rushabh(dot)lathia(at)gmail(dot)com |
| Subject: | Re: [PATCH] Keeps tracking the uniqueness with UniqueKey |
| Date: | 2020-06-29 09:59:21 |
| Message-ID: | CAKU4AWrT=o0dEmdFCH3W6B=BeUS1=OU5N86FfAmKFUahSP48SA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I just did another self-review about this patch and took some suggestions
based
on the discussion above. The attached is the v9 version. When you check
the
uniquekey patch, README.uniquekey should be a good place to start with.
Main changes in v9 includes:
1. called populate_baserel_uniquekeys after check_index_predicates.
2. removed the UniqueKey->onerow flag since we can tell it by exprs == NIL.
3. expression index code improvement.
4. code & comments refactoring.
As for the Index Skip Scan, I still have not merged the changes in the
Index
Skip Scan patch[1]. We may need some addition for that, but probably not
need to modify the existing code. After we can finalize it, we can add it
in
that patch. I will keep a close eye on it as well.
[1]:
https://www.postgresql.org/message-id/flat/20200609102247.jdlatmfyeecg52fi%40localhost
--
Best Regards
Andy Fan
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0005-Treat-the-input-as-sorted-if-the-group-by-clause-.patch | application/octet-stream | 13.2 KB |
| v9-0001-Introduce-RelOptInfo-notnullattrs-attribute.patch | application/octet-stream | 4.8 KB |
| v9-0003-Refactoring-existing-uniqueness-related-code-to-u.patch | application/octet-stream | 19.2 KB |
| v9-0004-Remove-distinct-node-AggNode-if-the-input-is-uniq.patch | application/octet-stream | 26.3 KB |
| v9-0002-Introduce-UniqueKey-attributes-on-RelOptInfo-stru.patch | application/octet-stream | 58.6 KB |
| v9-0006-Join-removal-at-run-time-with-UniqueKey.patch | application/octet-stream | 14.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-06-29 10:02:00 | Re: estimation problems for DISTINCT ON with FDW |
| Previous Message | Peter Eisentraut | 2020-06-29 09:58:11 | Re: update substring pattern matching syntax |