Re: [HACKERS] Runtime Partition Pruning

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Beena Emerson <memissemerson(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: [HACKERS] Runtime Partition Pruning
Date: 2018-04-05 02:01:46
Message-ID: CAKJS1f_QN-nmf6jCQ4gRU_8ab0zrd0ms-U=_Dj0KUARJiuGpOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5 April 2018 at 05:31, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> wrote:
> Patch v49 with v18 (0001-0004) works. 0005 needs a rebase.

I've attached an updated patchset against Amit's v49 faster partition
pruning patch [1].

v49 should also be patched with [2] and [3].

I'm pretty happy with patches 0001 to 0004. At the moment I'm still a
bit unsure of 0005. I need to do a bit more sanity checking on it,
mostly around the changes in planner.c. Although I am keen to see 0005
make it into PG11 as it does make running larger numbers of partition
more usable for UPDATE/DELETE too. Amit's improvements are really good
alone, but unfortunately, anyone who's waiting on us speeding up the
partition pruning in SELECT queries is probably also waiting on us
doing the same for UPDATE/DELETE. So I do think 0005 is important for
PG11, providing it's correct, of course.

[1] https://www.postgresql.org/message-id/c5331ff6-8b31-0742-758e-bd7b9aeddf07%40lab.ntt.co.jp
[2] https://www.postgresql.org/message-id/CAKJS1f_ad%3DB9rVf5dPD27%3DxTN1Ob7xJi6N4BFBNytj93rCPqzg%40mail.gmail.com
[3] https://www.postgresql.org/message-id/3eedafaa-840f-bf72-2fa9-dadb0852e959%40redhat.com

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
v19-0001-Provide-infrastructure-to-allow-partition-prunin.patch application/octet-stream 42.1 KB
v19-0002-Add-bms_prev_member-function.patch application/octet-stream 5.3 KB
v19-0003-Allow-Append-subnodes-to-be-pruned-during-execut.patch application/octet-stream 87.2 KB
v19-0004-Allow-MergeAppend-s-subnodes-to-be-pruned-during.patch application/octet-stream 18.4 KB
v19-0005-Improve-planning-speed-of-partitioned-table-UPDA.patch application/octet-stream 26.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-04-05 02:13:23 Re: pgsql: New files for MERGE
Previous Message Andres Freund 2018-04-05 01:44:39 Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key