From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Paul Ramsey <pramsey(at)cleverelephant(dot)ca>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Parallel Aggregate |
Date: | 2016-03-16 10:49:41 |
Message-ID: | CAKJS1f9w2-O9hRYw1FXEskm6+T2oGuHd8WzMxVm+UtK7pB1gGg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 16 March 2016 at 15:04, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I don't think I'd be objecting if you made PartialAggref a real
> alternative to Aggref. But that's not what you've got here. A
> PartialAggref is just a wrapper around an underlying Aggref that
> changes the interpretation of it - and I think that's not a good idea.
> If you want to have Aggref and PartialAggref as truly parallel node
> types, that seems cool, and possibly better than what you've got here
> now. Alternatively, Aggref can do everything. But I don't think we
> should go with this wrapper concept.
Ok, I've now gotten rid of the PartialAggref node, and I'm actually
quite happy with how it turned out. I made
search_indexed_tlist_for_partial_aggref() to follow-on the series of
other search_indexed_tlist_for_* functions and have made it behave the
same way, by returning the newly created Var instead of doing that in
fix_combine_agg_expr_mutator(), as the last version did.
Thanks for the suggestion.
New patch attached.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Allow-aggregation-to-happen-in-parallel_2016-03-16.patch | application/octet-stream | 45.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2016-03-16 10:54:44 | Re: Combining Aggregates |
Previous Message | Shulgin, Oleksandr | 2016-03-16 10:49:07 | Re: pg_hba_lookup function to get all matching pg_hba.conf entries |