| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | A small tweak to some comments for PartitionKeyData |
| Date: | 2018-10-25 03:43:04 |
| Message-ID: | CAKJS1f9mRdrvfZP-_PG-UoM30Dmj9HLnfrbOdLmAE=6fB8b1VA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While doing a bit of work on a partitioning patch I noticed that it's
not really that obvious that there's meant to be exactly 1 item in the
partexprs List for each zero-valued partattrs element. Some incorrect
code using these fields was the cause of CVE-2018-1052, so I think
it's worthwhile to mention how they should be used in the comments.
Patch attached.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| reword_comments_in_partitionkeydata_struct.patch | application/octet-stream | 771 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-10-25 03:46:44 | Re: A small tweak to some comments for PartitionKeyData |
| Previous Message | Michael Paquier | 2018-10-25 03:42:37 | Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER |