| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Beena Emerson <memissemerson(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, amul sul <sulamul(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Runtime Partition Pruning |
| Date: | 2018-01-05 00:54:35 |
| Message-ID: | CAKJS1f9Tavq5MuVVuzjp9EvPtj8GBnyunBUX61sERc9dwjWVMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 5 January 2018 at 05:37, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> I tried this patch (applying it on Amit's last current version on top of
> 4e2970f8807f which is the latest it applies to) and regression tests
> fail with the attached diff; in all cases it appears to be an off-by-one
> in row count. Would you please give it a look?
Thanks for testing. I've attached an updated patch which hopefully fixes this.
I've only thing I did to fix it was to alter the tests a bit so that
the row counts in explain are evenly divisible by the nloops or
parallel workers. Looks like it was failing due to platform dependent
behaviour in printf.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| runtime_prune_drowley_v5.patch | application/octet-stream | 102.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-01-05 01:00:11 | Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256 |
| Previous Message | David Rowley | 2018-01-04 23:58:24 | Re: [HACKERS] Runtime Partition Pruning |