Re: executor relation handling

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: executor relation handling
Date: 2018-09-29 00:46:36
Message-ID: CAKJS1f8uCk937hbTN5Fud+etubv5mczhguwabgaqQ_qr_Woe7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 29 September 2018 at 03:49, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> On 2018-Sep-28, Amit Langote wrote:
>> On 2018/09/28 17:48, David Rowley wrote:
>
>> > Meh, I just noticed that the WARNING text claims "InitPlan" is the
>> > function name. I think it's best to get rid of that. It's pretty much
>> > redundant anyway if you do: \set VERBOSITY verbose
>>
>> Oops, good catch that one. Removed "InitPlan: " from the message in the
>> attached.
>
> Were there two cases of that? Because one still remains.

Yeah, 0001 added it and 0004 removed it again replacing it with the
corrected version.

I've attached v10 which fixes this and aligns the WARNING text in
ExecInitRangeTable() and addRangeTableEntryForRelation().

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
v10-0001-Don-t-lock-range-table-relations-in-the-executor.patch application/octet-stream 44.0 KB
v10-0002-Remove-useless-fields-from-planner-nodes.patch application/octet-stream 43.4 KB
v10-0003-Prune-PlanRowMark-of-relations-that-are-pruned-f.patch application/octet-stream 2.4 KB
v10-0004-Revise-executor-range-table-relation-opening-clo.patch application/octet-stream 39.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Wong 2018-09-29 01:03:09 Re: Odd 9.4, 9.3 buildfarm failure on s390x
Previous Message Don Seiler 2018-09-28 23:59:07 Re: [PATCH] Include application_name in "connection authorized" log message