| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, John Naylor <john(dot)naylor(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Delay locking partitions during INSERT and UPDATE |
| Date: | 2019-02-20 21:56:17 |
| Message-ID: | CAKJS1f8JaEDTtUyQ53u7AzQFgu9tQLx1DJVTObOsWF9c7hUyfQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 21 Feb 2019 at 10:32, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> I spent some time thinking about that exact issue this morning and
> studying the code to try to figure that out. I wasn't able to find
> any other places that seemed to need updating, but it could be that I
> missed something that David also missed.
It looks like the comment that claimed the table was already locked
crept back in during a (seemingly) sloppy rebase after the
relation_open() -> table_open() change.
I've made a pass over this again and updated the header comments in
functions that now obtain a lock to mention that fact.
Also slightly updated commit msg in the patch.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-On-demand-locking-of-partitions-during-INSERT-and.patch | application/octet-stream | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gilles Darold | 2019-02-20 22:26:00 | [patch] Add schema total size to psql \dn+ |
| Previous Message | Stephen Frost | 2019-02-20 21:43:35 | Re: WAL insert delay settings |