| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Removing [Merge]Append nodes which contain a single subpath |
| Date: | 2018-02-19 09:02:24 |
| Message-ID: | CAKJS1f8AuJvM49KnnCMbvN5nCD0fwEa6pyKJysB7QLnKfun=sQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19 February 2018 at 18:01, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 19 February 2018 at 15:11, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> and perhaps we should do s/isproxy/is_proxy/ which seems like the usual
>> naming for boolean variables.
>
> You're right. I'll change that and post an updated patch. I'll also
> reprocess your email again and try to improve some comments to make
> the intent of the code more clear.
I've made a few changes to the patch. "isproxy" is now "is_proxy".
I've made the comments a bit more verbose at the top of the definition
of struct AppendPath. Also shuffled some comments around in allpaths.c
I've attached both a delta patch with just these changes, and also a
completely new patch based on a recent master.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_singleton_appends_2018-02-19_delta.patch | application/octet-stream | 7.9 KB |
| remove_singleton_appends_2018-02-19.patch | application/octet-stream | 62.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-02-19 09:19:29 | Re: [HACKERS] path toward faster partition pruning |
| Previous Message | Fabien COELHO | 2018-02-19 07:43:52 | Re: pgbench - allow to specify scale as a size |