Re: Switching to 64-bit Bitmapsets

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Switching to 64-bit Bitmapsets
Date: 2018-12-20 06:44:10
Message-ID: CAKJS1f86dQVX1u7JEjUPt3YbV7qm5faV_C9-+6ojy2bf2y4H4g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 20 Dec 2018 at 17:50, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> > However, I doubt it would take much more effort to maintain
> > using 32-bit sets on 32-bit machines. If someone feels strongly about
> > that then I can adjust the patch to allow that.
>
> Hm, are you thinking of making BITS_PER_BITMAPWORD match sizeof(Pointer)
> or something like that? That seems like a good compromise from here.

Yeah, something along those lines. I've implemented that in the attached.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
v2-0001-Change-Bitmapset-from-32-bit-to-64-bits-on-64-bit.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Gavin Flower 2018-12-20 07:17:28 Re: Using POPCNT and other advanced bit manipulation instructions
Previous Message Amit Kapila 2018-12-20 06:37:49 Re: [HACKERS] Block level parallel vacuum