Re: Switching to 64-bit Bitmapsets

From: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Switching to 64-bit Bitmapsets
Date: 2018-12-20 19:33:24
Message-ID: CAKJS1f850G43Yc_6nTVi+mS2iAJHJTr9Wwzb+RBuJ5SwgiX+HQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, 21 Dec 2018 at 06:26, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Pushed with some fiddling with the comment.

Great. Thanks!

> I wasn't excited about the test case you offered --- on HEAD, it pretty
> much all devolves to file access operations (probably, checking the
> current length of all the child relations). Instead I experimented
> with an old test case I had for a complex-to-plan query, and got these
> results:

oh meh. I forgot to mention I was running with plan_cache_mode =
force_generic_plan and max_parallel_workers_per_gather = 0. If you
tried without those then you'd have seen a massively different result.

Your test seems better, regardless.

--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2018-12-20 19:45:23 Re: lock level for DETACH PARTITION looks sketchy
Previous Message Alvaro Herrera 2018-12-20 18:13:09 Re: lock level for DETACH PARTITION looks sketchy