| From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: patch: Allow \dd to show constraint comments |
| Date: | 2011-09-11 14:11:49 |
| Message-ID: | CAK3UJRFqohei37EsW1fHF8qO_ESaAznFV6GiqSruebvmGE7WVw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 10, 2011 at 7:47 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> Just tested this out on current master. I tried this on every object
> capable of having a comment, and the view reports all of them with the
> correct details. Doc changes look fine, except for some reason you
> removed a full-stop (period) from after "For all other object types,
> this column is zero."
Thanks for the review. Looks like I got confused about where I was
whacking around in catalogs.sgml, good catch of a spurious change.
Fixed patch attached.
Josh
| Attachment | Content-Type | Size |
|---|---|---|
| pg_comments.v18.patch | application/octet-stream | 70.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2011-09-11 14:25:07 | Re: pg_dump.c |
| Previous Message | Peter Eisentraut | 2011-09-11 12:24:36 | Re: [COMMITTERS] pgsql: Add missing format attributes |