Re: [HACKERS] GSoC 2017: Foreign Key Arrays

Hey Justin,

Thank you for your review!

gram.y:16933:20: error: invalid operands to binary expression ('List' (aka
> 'struct List') and 'void *')
> Assert(**reftypes != NULL);
>
> Did you mean to write this, before the assignment of NIL ?
>
Fixed in v5 below.

> The windows build succeeded, but checks failed like:
>
> SELECT * FROM FKTABLEFORARRAYGIN WHERE ftest1 @>> 5;
> ftest1 | ftest2
> --------------+--------
> - {5} | 1
> - {3,5,2,5} | 3
> - {3,5,4,1,3} | 5
> - {5,1} | 7
> - {3,4,5,3} | 10
> -(5 rows)
> +--------+--------
> +(0 rows)

can't seem to reproduce it. Will try to debug them with the next CI check.

I suggest to generate the patch series with:
>
git format-patch -v2 origin.. -o patch/foreign-key-arrays/
>
I like this format, thanks for the suggestion!

Changelog:
- v5 (compatible with current master 2021-2-23,
commit 8deb6b38dc4c7a7fd4719ee45e4b00d62b27dffe)
* correct all reported spelling mistakes
* correct bug in "gram.y"

/Mark