| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
| Subject: | Re: current_logfiles not following group access and instead follows log_file_mode permissions |
| Date: | 2019-03-21 01:52:14 |
| Message-ID: | CAJrrPGf+kOZVGet6-uCi0c7dTsckU5BdeKfGQEK4d1_Joouk8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 21, 2019 at 12:41 PM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:
>
> On Wed, Mar 20, 2019 at 4:33 PM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
>
>> And actually it seems to me that you have a race condition in that
>> stuff. I think that you had better use umask(), then fopen, and then
>> once again umask() to put back the previous permissions, removing the
>> extra chmod() call.
>>
>
> Changed the patch to use umask() instead of chmod() according to
> your suggestion.
>
> updated patch attached.
>
Earlier attached patch is wrong.
Correct patch attached. Sorry for the inconvenience.
Regards,
Haribabu Kommi
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Adjust-current_logfiles-file-permissions_v3.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-03-21 03:10:17 | Re: DNS SRV support for LDAP authentication |
| Previous Message | Haribabu Kommi | 2019-03-21 01:45:57 | Re: MSVC Build support with visual studio 2019 |