Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Vaishnavi Prabakaran <vaishnaviprabakaran(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Refactor handling of database attributes between pg_dump and pg_dumpall
Date: 2018-01-05 05:32:05
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Fri, Jan 5, 2018 at 2:54 PM, Vaishnavi Prabakaran <
vaishnaviprabakaran(at)gmail(dot)com> wrote:

> On Wed, Dec 13, 2017 at 1:50 PM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
>> Rebased patch attached that fixes the documentation build problem.
>> Latest patch applies without noise. And here are some minor comments

Thanks for the review.

> + <varlistentry>
> + <term><option>--set-db-properties</option></term>
> + <listitem>
> + <para>
> + This option is to skip create database command without ignoring
> the rest
> + of the DATABASE specific commands and it is used when the
> database already
> + exists in the restore location. This option cannot be used with
> either of
> + <option>-C/--create</option> or <option>-c/--clean</option>
> options.
> + </para>
> I see the description is framed based on previous flag "
> --skip-default-create-db" , and I think this needs to be re-phrased to
> describe what it does , e.g: This option is to set database properties for
> already existing database without issuing create database command ....".

Updated with more details.

+ printf(_(" --set-db-properties dump db properties, for use by
> upgrade utilities only\n"));
> After the discussion about its usage up-thread, this needs to be corrected.

Updated patch attached.

Hari Babu
Fujitsu Australia

Attachment Content-Type Size
pg_dump-and-pg_dumpall-database-handling-refactoring_v12.patch application/octet-stream 49.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-01-05 05:47:54 Re: Condition variable live lock
Previous Message Tom Lane 2018-01-05 04:27:09 Re: Condition variable live lock