Re: macaddr 64 bit (EUI-64) datatype support

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
Cc: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macaddr 64 bit (EUI-64) datatype support
Date: 2017-01-31 12:39:53
Message-ID: CAJrrPGeT8zrGPMcRVk_wRvYD-ETcgUz6WRrc2C=iNubMRkrMxw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Jan 31, 2017 at 4:13 PM, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
wrote:

> On 1/27/17, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> > Updated patches are attached.
>
>
> Hello,
>
> I'm almost ready to mark it as Ready for committer.
> The final round.

Thanks for the review.

> 1.
> >+DATA(insert OID = 774 ( macaddr8 ...
> >+#define MACADDR8OID 972
> What does this number (972) mean? I think it should be 774, the same
> number as was used in the type definition.
>

I think I might have missed to update during OID number changes.
Fixed.

>
> Since there is an editing required, please, fix whitespaces:
> 2.
> >+DATA(insert OID = 3371 ( 403 macaddr8_ops
> PGNSP PGUID ));
> >+DATA(insert OID = 3372 ( 405 macaddr8_ops
> PGNSP PGUID ));
>
> only one (not three) tab before "PGNSP" should be used (see other rows
> around yours: "OID = 1983", "OID = 1991" etc).
>

Corrected.

> 3.
> >diff --git a/contrib/btree_gist/Makefile b/contrib/btree_gist/Makefile
> some new rows have two tabs instead of eight spaces.
>

Corrected.

> 4.
> Some other files need to be fixed by pgindent (it helps supporting in
> the future):
> contrib/btree_gist/btree_macaddr8.c (a lot of rows)
> src/include/utils/inet.h (I have no idea why it changes indentation
> to tabs for macaddr8 whereas it leaves spaces for macaddr)
>

Done.

5.
> src/backend/utils/adt/network.c
> pg_indent makes it uglier. I've just found how to write the line for it:
> res *= ((double) 256) * 256 * 256 * 256;

Done.

Updated patches are attached.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
contrib_macaddr8_3.patch application/octet-stream 19.9 KB
mac_eui64_support_10.patch application/octet-stream 47.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shinoda, Noriyoshi 2017-01-31 12:46:18 Logical Replication and Character encoding
Previous Message Rahila Syed 2017-01-31 12:23:50 Re: Parallel Index Scans