Re: macaddr 64 bit (EUI-64) datatype support

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macaddr 64 bit (EUI-64) datatype support
Date: 2017-01-05 01:08:09
Message-ID: CAJrrPGeRXJo_SnPqBGvTPKRXxMj7uGDYAXZyNjv9KqJTR2ZngQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 29, 2016 at 8:36 PM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:

>
>
> On Sat, Nov 26, 2016 at 4:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
>> Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> writes:
>> > Currently the casting is supported from macaddr to macaddr8, but not the
>> > other way. This is because, not all 8 byte MAC addresses can be
>> converted
>> > into 6 byte addresses.
>>
>> Well, yeah, so you'd throw an error if it can't be converted. This is
>> no different from casting int8 to int4, for example. We don't refuse
>> to provide that cast just because it will fail for some values.
>>
>
> Updated patch attached with added cast function from macaddr8 to
> macaddr.
>
> Currently there are no support for cross operators. Is this required
> to be this patch only or can be handled later if required?
>

Updated patch attached to address the duplicate OID problem.
There are no other functional changes to the previous patch.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
mac_eui64_support_4.patch application/octet-stream 52.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2017-01-05 01:19:16 Re: Logical decoding on standby
Previous Message Craig Ringer 2017-01-05 00:54:11 Re: Replication slot xmin is not reset if HS feedback is turned off while standby is shut down