From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Exclude pg_internal.init from base backup |
Date: | 2017-11-08 00:50:07 |
Message-ID: | CAJrrPGdkL8TFk+-VivrW637js0v_KM=ub4pBFy=Nf0bpafByhw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 8, 2017 at 11:11 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
> On Wed, Nov 8, 2017 at 9:04 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
> > The commit 98267e missed to check the empty SGML tag, attached patch
> > fixes the same.
>
> <listitem>
> <para>
> - <filename>pg_internal.init (found in multiple directories)</>
> + <filename>pg_internal.init (found in multiple
> directories)</filename>
> </para>
> </listitem>
> What has been committed in 98267ee and what is proposed here both look
> incorrect to me. The markup filename ought to be used only with file
> names, so "(found in multiple directories)" should not be within it.
> Simon's commit is not wrong with the markup usage by the way.
>
Thanks for the correction. I was not much aware of SGML markup usage.
While building the documentation, it raises an warning message of "empty
end-tag".
So I just added the end tag. Attached the update patch with the suggested
correction.
Regards,
Hari Babu
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
sgml_empty_tag_fix_v2.patch | application/octet-stream | 501 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-11-08 00:58:45 | Re: Exclude pg_internal.init from base backup |
Previous Message | Nico Williams | 2017-11-08 00:45:52 | Re: MERGE SQL Statement for PG11 |