Re: Refactor handling of database attributes between pg_dump and pg_dumpall

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Refactor handling of database attributes between pg_dump and pg_dumpall
Date: 2017-09-09 03:29:45
Message-ID: CAJrrPGdXKJWfePdP0Z0cid051jsR3cdwJ1Q4Lg+OsLFRf_mFqg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com
> wrote:

> On Mon, Aug 21, 2017 at 4:35 PM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> > On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut
> > <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> >> On 4/4/17 01:06, Haribabu Kommi wrote:
> >> > Both pg_dump and pg_upgrade tests are passed. Updated patch attached
> >> > I will add this patch to the next commitfest.
> >>
> >> This patch needs to be rebased for the upcoming commit fest.
> >
> > Thanks for checking. Rebased patch is attached.
>
> Hi Haribabu,
>
> This patch breaks the documentation build, possibly because of these empty
> tags:
>
> + <option>--create</option> option to dump <>ALTER ROLE IN
> DATABASE ... SET</>
>

Thanks for checking the patch.
Fixed patch is attached.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
0001-pg_dump-and-pg_dumpall-database-handling-refactoring_v7.patch application/octet-stream 49.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-09-09 03:35:40 Re: Cached plans and statement generalization
Previous Message Haribabu Kommi 2017-09-09 03:23:32 Re: Pluggable storage