Re: Pluggable Storage - Andres's take

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Asim R P <apraveen(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: Pluggable Storage - Andres's take
Date: 2019-02-20 03:39:32
Message-ID: CAJrrPGdN+rW_JcwFUcZrqDw8NQnu2xi6ug3nQMjGPpVEYU-4pQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Feb 4, 2019 at 2:31 PM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
wrote:

>
> On Tue, Jan 22, 2019 at 1:43 PM Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
>
>>
>>
>> OK. I will work on the doc changes.
>>
>
> Sorry for the delay.
>
> Attached a draft patch of doc and comments changes that I worked upon.
> Currently I added comments to the callbacks that are present in the
> TableAmRoutine
> structure and I copied it into the docs. I am not sure whether it is a
> good approach or not?
> I am yet to add description for the each parameter of the callbacks for
> easier understanding.
>
> Or, Giving description of each callbacks in the docs with division of
> those callbacks
> according to them divided in the TableAmRoutine structure? Currently
> following divisions
> are available.
> 1. Table scan
> 2. Parallel table scan
> 3. Index scan
> 4. Manipulation of physical tuples
> 5. Non-modifying operations on individual tuples
> 6. DDL
> 7. Planner
> 8. Executor
>
> Suggestions?
>

Here I attached the doc patches for the pluggable storage, I divided the
API's into the above
specified groups and explained them in the docs.I can further add more
details if the approach
seems fine.

Regards,
Haribabu Kommi
Fujitsu Australia

Attachment Content-Type Size
0008-Table-access-method-API-explanation.patch application/octet-stream 23.8 KB
0001-Docs-of-default_table_access_method-GUC.patch application/octet-stream 2.0 KB
0002-Rename-indexam.sgml-to-am.sgml.patch application/octet-stream 2.3 KB
0003-Reorganize-am-as-both-table-and-index.patch application/octet-stream 4.0 KB
0004-Doc-update-of-Create-access-method-type-table.patch application/octet-stream 2.8 KB
0005-Doc-update-of-create-materialized-view-.-USING-synta.patch application/octet-stream 2.1 KB
0006-Doc-update-of-CREATE-TABLE-.-USING-syntax.patch application/octet-stream 4.5 KB
0007-Doc-of-CREATE-TABLE-AS-.-USING-syntax.patch application/octet-stream 2.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2019-02-20 03:44:21 Re: Pluggable Storage - Andres's take
Previous Message Michael Paquier 2019-02-20 03:38:01 Re: Incorrect visibility test function assigned to snapshot