Re: macaddr 64 bit (EUI-64) datatype support

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Shay Rojansky <roji(at)roji(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: macaddr 64 bit (EUI-64) datatype support
Date: 2017-01-24 04:55:08
Message-ID: CAJrrPGdC-Fmy3D-y4SQFq9B_ywwZO-nFYr0irS0GP3x91_Rk+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Jan 23, 2017 at 6:29 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
wrote:

> On Thu, Jan 19, 2017 at 7:46 AM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
> >
> > Updated patch attached.
> >
> I've looked at the updated patch. There are still some changes that
> needs to be done. It includes:
>

Thanks for the review.

1. Adding macaddr8 support for btree_gist and testcases.
> 2. Implementation of macaddr8 support for btree_gin is incomplete. You
> need to modify contrib/btree_gin/*.sql files as well. Also, testcases
> needs to be added.
>

Added the support for macaddr8 datatype for both btree_gin and btree_gist
modules and the tests also.

I didn't update the *.sql files to the latest version and just added the
update *.sql
file only as like earlier changes on btree_gist for UUID support to make it
easier
for the reviewer.

The patch is split into two parts.
1. Macaddr8 datatype support
2. Contrib module support.

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
mac_eui64_support_7.patch application/octet-stream 46.9 KB
contrib_macaddr8_1.patch application/octet-stream 20.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2017-01-24 04:59:32 Re: New SQL counter statistics view (pg_stat_sql)
Previous Message Dilip Kumar 2017-01-24 04:48:29 Re: Parallel bitmap heap scan