Re: Patch: Write Amplification Reduction Method (WARM)

From: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Write Amplification Reduction Method (WARM)
Date: 2016-11-15 06:58:03
Message-ID: CAJrrPGc7w4aB17zHh-S4xvZRg-CTE8cDxsX7yHW4H-sGrTJN2g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Nov 12, 2016 at 10:12 PM, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>
wrote:

>
>
> On Tue, Nov 8, 2016 at 9:13 AM, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
> wrote:
>
>>
>> Thanks for the patch. This shows a very good performance improvement.
>>
>>
> Thank you. Can you please share the benchmark you ran, results and
> observations?
>

I just ran a performance test on my laptop with minimal configuration, it
didn't show much
improvement, currently I don't have access to a big machine to test the
performance.

> I started reviewing the patch, during this process and I ran the regression
>> test on the WARM patch. I observed a failure in create_index test.
>> This may be a bug in code or expected that needs to be corrected.
>>
>
> Can you please share the diff? I ran regression after applying patch on
> the current master and did not find any change? Does it happen consistently?
>

Yes, it is happening consistently. I ran the make installcheck. Attached
the regression.diffs file with the failed test.
I applied the previous warm patch on this commit -
e3e66d8a9813d22c2aa027d8f373a96d4d4c1b15

Regards,
Hari Babu
Fujitsu Australia

Attachment Content-Type Size
regression.diffs application/octet-stream 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2016-11-15 08:03:24 Re: [PATCH] Generic type subscription
Previous Message Kyotaro HORIGUCHI 2016-11-15 03:57:25 Re: Fix checkpoint skip logic on idle systems by tracking LSN progress