| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Synchronizing slots from primary to standby |
| Date: | 2024-02-07 12:01:50 |
| Message-ID: | CAJpy0uDm5MWMD1XNFh9as0jSmjKQcPvv-9W7WHcYVh4uUEbg-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 7, 2024 at 4:29 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> ...
> > drop_obsolete_slots drop_local_synced_slots
>
> The new name doesn't convey the intent of the function. If we want to
> have a difference based on remote/local slots then we can probably
> name it as drop_local_obsolete_slots.
>
> > reserve_wal_for_slot reserve_wal_for_local_slot
> > local_slot_update update_local_synced_slot
> > update_and_persist_slot update_and_persist_local_synced_slot
> >
>
> The new names sound better in the above cases as the current names
> appear too generic.
Sure, made the suggested function name changes. Since there is no
other change, I kept the version as v80_2.
thanks
Shveta
| Attachment | Content-Type | Size |
|---|---|---|
| v80_2-0004-Document-the-steps-to-check-if-the-standby-is-.patch | application/octet-stream | 6.6 KB |
| v80_2-0003-Allow-logical-walsenders-to-wait-for-the-physi.patch | application/octet-stream | 42.4 KB |
| v80_2-0002-Add-a-new-slotsync-worker.patch | application/octet-stream | 56.3 KB |
| v80_2-0001-Add-a-slot-synchronization-function.patch | application/octet-stream | 72.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Luzanov | 2024-02-07 12:35:34 | Re: Psql meta-command conninfo+ |
| Previous Message | Dilip Kumar | 2024-02-07 11:58:41 | Re: Synchronizing slots from primary to standby |