| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2025-10-21 04:03:29 |
| Message-ID: | CAJpy0uCvHmDdp7W1kDvVEwFT2+V9gnj5boE5+mtUqVknE9-bvQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 20, 2025 at 5:29 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > Here is the latest patch set which addressed Shveta[1], Amit[2], Chao[3][4],
> > Dilip[5], Sawada-San's[6] comments.
>
> I found the patch could not pass the sanity check, because 0001 missed a comma.
> Also, there was a duplicated entry for `REFRESH SEQUENCES`.
>
> Attached set fixed the issue.
>
Thanks for the patch. I tried to compile the doc of patch001 alone. It
did not go through, errors:
postgres.sgml:198: element xref: validity error : IDREF attribute
linkend references an unknown ID "sequence-definition-mismatches"
postgres.sgml:234: element xref: validity error : IDREF attribute
linkend references an unknown ID "sequence-definition-mismatches"
postgres.sgml:239: element xref: validity error : IDREF attribute
linkend references an unknown ID "sequences-out-of-sync"
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2025-10-21 04:07:19 | Re: Eliminating SPI / SQL from some RI triggers - take 3 |
| Previous Message | jian he | 2025-10-21 04:00:28 | Re: remove unnecessary include in src/backend/commands/policy.c |