Re: Synchronizing slots from primary to standby

From: shveta malik <shveta(dot)malik(at)gmail(dot)com>
To: Ajin Cherian <itsajin(at)gmail(dot)com>
Cc: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Synchronizing slots from primary to standby
Date: 2024-02-05 11:26:16
Message-ID: CAJpy0uBNG6iBHFOLH3jmbC3Dyiy3m5EO6_+2nyk=A08s+F-PYQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 5, 2024 at 10:57 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> Just noticed that doc/src/sgml/config.sgml still refers to enable_synclot instead of sync_replication_slots:
>
> The standbys corresponding to the physical replication slots in
> <varname>standby_slot_names</varname> must configure
> <literal>enable_syncslot = true</literal> so they can receive
> failover logical slots changes from the primary.

Thanks Ajin for pointing this out. Here are v78 patches, corrected there.

Other changes are:

1) Rebased the patches as the v77-001 is now pushed.
2) Enabled executing pg_sync_replication_slots() on cascading-standby.
3) Rearranged the code around parameter validity checks. Changed
function names and changed the way how dbname is extracted as
suggested by Amit offlist.
4) Rearranged the code around check_primary_info(). Removed output args.
5) Few other trivial changes.

thanks
Shveta

Attachment Content-Type Size
v78-0001-Add-a-slot-synchronization-function.patch application/octet-stream 62.3 KB
v78-0003-Allow-logical-walsenders-to-wait-for-the-physica.patch application/octet-stream 40.8 KB
v78-0004-Document-the-steps-to-check-if-the-standby-is-re.patch application/octet-stream 6.6 KB
v78-0002-Add-a-new-slotsync-worker.patch application/octet-stream 53.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2024-02-05 11:28:25 Re: Synchronizing slots from primary to standby
Previous Message Amit Kapila 2024-02-05 11:06:26 Re: Synchronizing slots from primary to standby